ci: check how fast/slow valgrind is on GA #2226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-try-valgrind-on-github-actions
branch
2 times, most recently
from
e75fd2e
to
0609bfc
Compare
because it's super slow (~1.5h) lately in my concourse instance
flavorjones
force-pushed
the
flavorjones-try-valgrind-on-github-actions
branch
from
0609bfc
to
d630d78
Compare
|
The test ran in ~28 minutes total, much faster than the concourse deployment on GCP. That's pretty compelling. |
4 tasks
|
Closing, will be rolling this into a new PR shortly. |
15 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Let's experiment with a
rake test:valgrindrun on Github Actions. This action is taking ~1.5h on my Concourse instance on GCP lately, and I'm not sure why (it used to only take ~30 minutes).Related to #2207