Clarify library dependencies in native gems #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit c454876 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 40.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.1% (-0.1% change). View more on Code Climate. |
also: - make extconf more consistent in using append_cppflags for CPP flags - jruby version also emits lib info this way
I think this is much more readable format as well.
flavorjones
force-pushed
the
2127-update-license-dependencies
branch
from
436c39f
to
c454876
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
See #2127 for background. We want to be clear about which dependencies are distributed in which gem files, and provide readable license informatino.
Have you included adequate test coverage?
Yes, for the changes in how VERSION_INFO is being presented.
Does this change affect the behavior of either the C or the Java implementations?
No functional changes outside of VersionInfo, which are captured in #2139.