-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up CSS class queries #2137
Commits on Dec 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7b76dc7 - Browse repository at this point
Copy the full SHA 7b76dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2145f9d - Browse repository at this point
Copy the full SHA 2145f9dView commit details -
feat: provide an XPath function for fast CSS class lookup
available as `nokogiri-builtin:css-class` Part of #2135
Configuration menu - View commit details
-
Copy full SHA for 7566d4b - Browse repository at this point
Copy the full SHA 7566d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91d6187 - Browse repository at this point
Copy the full SHA 91d6187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 671fd2f - Browse repository at this point
Copy the full SHA 671fd2fView commit details -
style: overhauled CSS parser tests to be more readable
and consolidated the XPathVisitor tests from css/test_parser.rb into css/test_xpath_visitor.rb so we're testing xpath visitor behavior in one place.
Configuration menu - View commit details
-
Copy full SHA for 206ac73 - Browse repository at this point
Copy the full SHA 206ac73View commit details -
refactor: simplify XPath translation of the CSS ~= operator
This is consistent with the class selector ".", and should be faster because it's doing less string manipulation in the XPath query.
Configuration menu - View commit details
-
Copy full SHA for 4d3eb8e - Browse repository at this point
Copy the full SHA 4d3eb8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4af18dc - Browse repository at this point
Copy the full SHA 4af18dcView commit details -
feat: Introduce variations of CSS::XPathVisitor that use builtins
This allows us to continue to generate XPath that uses standard XPath functions, but also allow us to inject the preference to use the optimized builtin implementation. This also leaves open a path to extracting Nokogiri's CSS parser into a separate gem, and allowing Nokogiri to inject builtin via a custom XPathVisitor class.
Configuration menu - View commit details
-
Copy full SHA for 9f5bb99 - Browse repository at this point
Copy the full SHA 9f5bb99View commit details -
feat: CSS queries use builtins if they are more performant
Notably, on libxml2 CSS class queries are now ~2x faster using the `nokogiri-builtin:css-class` function. Closes #2135
Configuration menu - View commit details
-
Copy full SHA for 5d0b7fe - Browse repository at this point
Copy the full SHA 5d0b7feView commit details