Test for handler functions not interfering with CSS id queries #1890
Conversation
|
Code Climate has analyzed commit 4cbe7b5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 93.5% (0.0% change). View more on Code Climate. |
|
I think the issue is at https://github.com/sparklemotion/nokogiri/blob/master/ext/java/nokogiri/XmlXpathContext.java#L123 where it appears to indiscriminately replace any matching text in the query whether it's something that could be a function call or not. |
|
Thanks for submitting this. Tagging @jvshahid so he's aware and maybe we can pair on it. |
|
This issue goes back to 468c757 in 2010 when XPath custom handler support was first added. It's because a very rough method is being use to try to infer method calls. Will stare at it a bit today. |
|
See #2147 for a suggested future path around this functionality. |
…space-inference fix(jruby): make less-naive inference of xpath custom function ns --- **What problem is this PR intended to solve?** Closes #1890 Related to #2147 JRuby's logic for inferring a namespace for the custom XPath function handler has been naive since it was introduced in 468c757. This PR makes it less naive and less likely to break things by looking for function calls in the query via regex, and looking for matches among the handler's declared Ruby methods. Ideally we should require namespaces in both JRuby and CRuby implementations at some point to avoid having to do this kind of heavy lifting. See #2147 for a proposal. **Have you included adequate test coverage?** Sure. **Does this change affect the behavior of either the C or the Java implementations?** Only changes the JRuby implementation, to do a better job of matching the CRuby behavior.
|
Will be fixed in v1.11.0.rc4, sorry for the delay. |
This PR adds a test for an issue that shows up when using JRuby. When using JRuby css id queries (at least - maybe others too) where the id partially contains the name of a function in the passed in handler causes the CSS to return no elements. This does not happen on MRI. Not really sure where to even start looking for the root cause.