Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of JRuby --1.8 legacy code in ext #1607

Merged
merged 2 commits into from
May 10, 2017
Merged

get rid of JRuby --1.8 legacy code in ext #1607

merged 2 commits into from
May 10, 2017

Conversation

kares
Copy link
Contributor

@kares kares commented Feb 14, 2017

... a #1606 follow-up

@flavorjones flavorjones added this to the 1.8.0 milestone Mar 20, 2017
@kares
Copy link
Contributor Author

kares commented Mar 22, 2017

Hey Mike, I am not sure the 1.8 wait is needed. Since 1.7.1 (thanks for the release) added the >= 1.9.3.
... or do you just prefer to have it that way? I'm asking cause I have some more JRuby pieces lying around.

@kares
Copy link
Contributor Author

kares commented Mar 22, 2017

oh, I see 1.7.1 was not done off master but only includes CVE fixes over 1.7.0 ... ignore that part than.

@flavorjones flavorjones merged commit 359ab15 into sparklemotion:master May 10, 2017
@flavorjones
Copy link
Member

Thanks so much! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kares @flavorjones