Look for bundled libs in lib64 else lib #1574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds awareness of the lib64 build convention. On openSUSE, MacOS, and perhaps other distros, the bundled libxml2 and libxslt libraries get built in a lib64 subdirectory per distro convention. This commit changes Nokogiri's hardcoded 'lib' convention to first check for bundled library existence in lib64, and if not found, falls back to lib.
|
Hi. Thanks for submitting this PR! As I commented on #1562, I haven't yet managed to reproduce what you're seeing, and would prefer not to try to evaluate a PR until I more completely understand the problem being solved. I'm going to close this PR for now; but I'm open to re-evaluating that decision once I better understand the problem we're trying to solve. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds awareness of the lib64 build convention. On openSUSE, MacOS, and perhaps other distros, the bundled libxml2 and libxslt libraries get built in a lib64 subdirectory per distro convention. This commit changes Nokogiri's hardcoded 'lib' convention to first check for bundled library existence in lib64, and if not found, falls back to lib.
See issue #1562 for details.