Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #843 #1327

Closed
wants to merge 3 commits into from
Closed

Fix for #843 #1327

wants to merge 3 commits into from

Commits on Aug 4, 2015

  1. Fixing issue where xml reader is choking while trying to access names… 

    …pace information tied to the attribute nodes
    @2potatocakes @codekitchen
    2potatocakes authored and codekitchen committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    f3d4ab9 View commit details
    Browse the repository at this point in the history

  2. Still managed to get an occasional segfault with my previous commit, … 

    …this change fixes the segfault
    @2potatocakes @codekitchen
    2potatocakes authored and codekitchen committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    b871a56 View commit details
    Browse the repository at this point in the history

  3. return the namespace even if it's not in the cache 

    This fixes Nokogiri::XML::Attr#namespace not working when used with XmlReader,
because namespaces never get cached in that scenario.

We can't add it to the cache at this point, because the node that defined the
namespace is not available.
    @codekitchen
    codekitchen committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    3ff719f View commit details
    Browse the repository at this point in the history