Fix for #843 - the xml reader bombs out when trying access attribute namespaces #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace information tied to the attribute nodes
…this change fixes the segfault
Closed
|
We really need this fix, so I tracked down the issue with the jruby implementation and added a fix. New PR is #1327 , since I don't think I can update this one. |
|
Closing this PR, superseded by #1327. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #843 for an example of the issue.
Was hoping for some help with this if anyone can lend a hand. Have added a test case which is now passing under C ruby but failing under jruby.
These commits fix an issue in the nokogiri reader when trying to access namespace properties on attribute nodes. Currently when trying to access them via the attribute_nodes method it halts the ruby interpreter :(
If you copy and paste the test case into master, without applying the patch you should be able to see the test suite crash mid way through.