Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License missing from gemspec #938

Closed
bf4 opened this issue Jul 15, 2013 · 5 comments
Closed

License missing from gemspec #938

bf4 opened this issue Jul 15, 2013 · 5 comments

Comments

@bf4
Copy link

bf4 commented Jul 15, 2013

Some companies will only use gems with a certain license.
The canonical and easy way to check is via the gemspec
via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

There is even a License Finder to help companies ensure all gems they use
meet their licensing needs. This tool depends on license information being available in the gemspec.
Including a license in your gemspec is a good practice, in any case.

How did I find you?

I'm using a script to collect stats on gems, originally looking for download data, but decided to collect licenses too,
and make issues for missing ones as a public service :)
https://gist.github.com/bf4/5952053#file-license_issue-rb-L13 So far it's going pretty well

@leejarvis
Copy link
Member

I wouldn't usually reply to an automated issue, but for reference: https://github.com/sparklemotion/nokogiri/blob/master/Y_U_NO_GEMSPEC.md

@bf4
Copy link
Author

bf4 commented Jul 15, 2013

That has nothing to do with whether there is a gemspec in the project, though. This issue is that the gem you are packaging and distributing doesn't have license = 'MIT' in it. So, obviously there can't be a PR here, but there can still be a license in the next released gem, right? :)

Thanks for the reply!

@knu knu reopened this Jul 16, 2013
@knu
Copy link
Member

knu commented Jul 16, 2013

I think we can add self.licenses = ['MIT'] to Rakefile in the Hoe.spec block.

@leejarvis
Copy link
Member

@bf4 My apologies for closing this with haste. We get a lot of issues regarding the gemspec and I wrongly closed without properly investigating. Thanks for reporting.

@bf4
Copy link
Author

bf4 commented Jul 16, 2013

@injekt @knu No problem. I'm familiar with the phenomenon 👪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants