-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-1840, ENG-1842] Add native dependencies for iOS #2693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HeavenVolkoff
force-pushed
the
ios-native-deps
branch
from
September 11, 2024 09:54
2a438df
to
f5c89ce
Compare
- Add a spinner animation to `pnpm prep` - Change abandoned dependency @iarna/toml with smol-toml - Validate cargo config.toml after generating it from mustache template - Disabled HTTP2 downloads with udici, it is very broken
- Remove app.json
HeavenVolkoff
force-pushed
the
ios-native-deps
branch
from
September 16, 2024 20:14
764e88a
to
89dc6f0
Compare
- Change SDCore.podspec to add extra libraries required by ffmpeg - Fix heif linking for ios in config.toml template - Add symlink logic for extra libraries required to compile ios in build-rust.sh
HeavenVolkoff
force-pushed
the
ios-native-deps
branch
from
September 16, 2024 20:49
89dc6f0
to
043a11f
Compare
HeavenVolkoff
changed the title
Add native dependencies for iOS
[ENG-1840] Add native dependencies for iOS
Sep 16, 2024
HeavenVolkoff
changed the title
[ENG-1840] Add native dependencies for iOS
[ENG-1840, ENG-1842] Add native dependencies for iOS
Sep 16, 2024
HeavenVolkoff
requested review from
fogodev and
Rocky43007
and removed request for
a team
September 17, 2024 01:28
Rocky43007
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works on physical and simulated iOS devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDCore.podspec
to link the native dependencies required for FFMpegbuild-rust.sh
to configure cargo so it can successfully build core with FFMpeg@iarna/toml
dependency withsmol-toml
preprep.mjs
preprep.mjs
preprep.mjs
, it is very brokenpreprep.mjs
P̶.̶S̶.̶:̶ ̶T̶h̶i̶s̶ ̶P̶R̶ ̶i̶s̶ ̶b̶l̶o̶c̶k̶e̶d̶ ̶u̶n̶t̶i̶l̶ ̶a̶ ̶n̶e̶w̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶o̶f̶ ̶[̶n̶a̶t̶i̶v̶e̶ ̶d̶e̶p̶s̶]̶(̶h̶t̶t̶p̶s̶:̶/̶/̶g̶i̶t̶h̶u̶b̶.̶c̶o̶m̶/̶s̶p̶a̶c̶e̶d̶r̶i̶v̶e̶a̶p̶p̶/̶n̶a̶t̶i̶v̶e̶-̶d̶e̶p̶s̶)̶ ̶i̶s̶ ̶r̶e̶l̶e̶a̶s̶e̶d̶ (Done: https://github.com/spacedriveapp/native-deps/releases/tag/v0.21)