Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1840, ENG-1842] Add native dependencies for iOS #2693

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

HeavenVolkoff
Copy link
Member

@HeavenVolkoff HeavenVolkoff commented Aug 29, 2024

  • Add support for native deps in iOS mobile app
  • Enable FFMpeg feature when compiling core for iOS
  • Add iOS specific cargo config
  • Update SDCore.podspec to link the native dependencies required for FFMpeg
  • Update build-rust.sh to configure cargo so it can successfully build core with FFMpeg
  • Replaced abadoned @iarna/toml dependency with smol-toml
  • Add support for download iOS native dependencies in preprep.mjs
  • Add a loading spinner animation when downloading files in preprep.mjs
  • Remove HTTP2 support from preprep.mjs, it is very broken
  • Add support to query installed rust targets in preprep.mjs

P̶.̶S̶.̶:̶ ̶T̶h̶i̶s̶ ̶P̶R̶ ̶i̶s̶ ̶b̶l̶o̶c̶k̶e̶d̶ ̶u̶n̶t̶i̶l̶ ̶a̶ ̶n̶e̶w̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶o̶f̶ ̶[̶n̶a̶t̶i̶v̶e̶ ̶d̶e̶p̶s̶]̶(̶h̶t̶t̶p̶s̶:̶/̶/̶g̶i̶t̶h̶u̶b̶.̶c̶o̶m̶/̶s̶p̶a̶c̶e̶d̶r̶i̶v̶e̶a̶p̶p̶/̶n̶a̶t̶i̶v̶e̶-̶d̶e̶p̶s̶)̶ ̶i̶s̶ ̶r̶e̶l̶e̶a̶s̶e̶d̶ (Done: https://github.com/spacedriveapp/native-deps/releases/tag/v0.21)

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 8:52pm
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 8:52pm

 - Add a spinner animation to `pnpm prep`
 - Change abandoned dependency @iarna/toml with smol-toml
 - Validate cargo config.toml after generating it from mustache template
 - Disabled HTTP2 downloads with udici, it is very broken
 - Remove app.json
 - Change SDCore.podspec to add extra libraries required by ffmpeg
 - Fix heif linking for ios in config.toml template
 - Add symlink logic for extra libraries required to compile ios in build-rust.sh
Copy link

linear bot commented Sep 16, 2024

@HeavenVolkoff HeavenVolkoff changed the title [ENG-1840] Add native dependencies for iOS [ENG-1840, ENG-1842] Add native dependencies for iOS Sep 16, 2024
Copy link

linear bot commented Sep 16, 2024

@HeavenVolkoff HeavenVolkoff marked this pull request as ready for review September 17, 2024 01:27
@HeavenVolkoff HeavenVolkoff requested a review from a team as a code owner September 17, 2024 01:27
@HeavenVolkoff HeavenVolkoff requested review from fogodev and Rocky43007 and removed request for a team September 17, 2024 01:28
Copy link
Member

@Rocky43007 Rocky43007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works on physical and simulated iOS devices

@HeavenVolkoff HeavenVolkoff added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 3bbea40 Sep 17, 2024
13 checks passed
@HeavenVolkoff HeavenVolkoff deleted the ios-native-deps branch September 17, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants