Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation issues #323

Closed
martin-g opened this issue Oct 21, 2014 · 3 comments
Closed

Documentation issues #323

martin-g opened this issue Oct 21, 2014 · 3 comments

Comments

@martin-g
Copy link
Contributor

Hi,

At http://bootstraptour.com/api/ there is a table with all available settings.
Few of them have confusing default values for their types:

  • backdropPadding has type Boolean|Object but its default value is 0, i.e. a Number
    Should the default be a false or the type Number|Object ?
  • duration's type is Boolean|String and its default value is false but the docu says that the alternative value is in milliseconds. So maybe the type should be Boolean|Number ?
  • Step delay/event #241 introduced delay option but it is not listed in the table
@sorich87
Copy link
Owner

Pull request? ;)

@martin-g
Copy link
Contributor Author

I hope the improvements are correct :)

#329

sorich87 added a commit that referenced this issue Oct 29, 2014
Fixes #323 - Fix the types for backdropPadding and duration. Add an entry for 'delay'
sorich87 added a commit that referenced this issue Feb 8, 2015
@miksh7
Copy link

miksh7 commented Mar 9, 2015

Same changes should be done in the step options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants