Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover shown below the navbar-fixed-top #125

Closed
LostCrew opened this issue Aug 10, 2013 · 5 comments
Closed

Popover shown below the navbar-fixed-top #125

LostCrew opened this issue Aug 10, 2013 · 5 comments
Assignees
Labels

Comments

@LostCrew
Copy link
Contributor

this is the result. i'm quite sure it's like this after the upgrade to support twitter bootstrap 3:

navbar fixed top bug

to solve it, we can set a higher z-index for the popovers with class tour.
@emmenko and @sorich87, looking forward to hear from you if you agree on the fix.

@ghost ghost assigned LostCrew Aug 10, 2013
@sorich87
Copy link
Owner

👍

@emmenko
Copy link
Contributor

emmenko commented Aug 11, 2013

Actually I was experiencing a similar problem in my application.
I had a step with an element in the fixed top-nav and when calling the step the popover (and the page) would "scroll" to the top of the window.

screen shot 2013-08-11 at 11 15 47 am

This happens when placement is bottom. Changing it to left or right would place it correctly.
And I was using bootstrap-tour 0.4 with twitter-bootstrap 2.3

@jlovison
Copy link

If you try this on a mobile device, the issue is compounded by the anchor element for the popover often disappearing off screen if the placement of the popover is "below" and half the popover being hidden by the navbar if the placement is "above".

If I might make a suggestion on this issue -- considering that the anchor element for the popover can be of varying size, the display height will vary, and the position of the popover relative to the anchor element can vary -- rather than trying to solve precise positioning for each possible scenario, why not handle the positioning issue the way ZURB's Joyride seems to, and just scroll such that the popover is in the middle of the viewport, rather than at the top?

The z-index fix will help for when the anchor is at the top of the page, but for anchors lower in a page, that fix will constantly render the navbar navigation inaccessible on mobile devices (due to the popover blocking the controls) without a "midline-scroll" as described above.

Edit: You can see a sample scroll function to do this in my comment on #114

@sorich87
Copy link
Owner

@Kromen, if you could submit a pull request based on the code you wrote in #114, that would be great.

@LostCrew
Copy link
Contributor Author

LostCrew commented Sep 1, 2013

close, done in v0.6.0 following #132 implementation.
thanks @kromem.

@LostCrew LostCrew closed this as completed Sep 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants