Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REACH and Eidos together #405

Merged
merged 12 commits into from
Feb 26, 2018
Merged

REACH and Eidos together #405

merged 12 commits into from
Feb 26, 2018

Conversation

bgyori
Copy link
Member

@bgyori bgyori commented Feb 26, 2018

This PR adds some CLASSPATH handling to allow more conveniently using REACH and Eidos and allow testing both on Travis. REACHPATH and EIDOSPATH point to the JAR file of each system. These two paths can either be on the CLASSPATH set by the user, or, if not on the CLASSPATH, the right one is added to the CLASSPATH in the respective reach_reader.py or eidos_reader.py.

One change is that REACHPATH now points to the REACH JAR rather than the folder that the REACH JAR is in, this is updated in the various readers. A simultaneous update in indra_deps_docker is ready to be pushed if this is merged.

This fixes #394 to the extent that both readers (and Biopax) can be used with a single fixed setting of environment variables, but due to fundamental limitations in jnius, using both readers in the same session is still not possible (i.e. from indra.sources import reach, eidos and then using both wouldn't work). It also fixes #359.

@bgyori
Copy link
Member Author

bgyori commented Feb 26, 2018

Despite these changes it doesn't seem possible to test both REACH and Eidos with a single nosetests call, even with the --with-isolation flag. Therefore I ended up separating out Eidos tests from the other tests.

@bgyori bgyori merged commit dfb6e17 into sorgerlab:master Feb 26, 2018
@bgyori bgyori deleted the reach_eidos branch February 26, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a way to use Reach/Eidos jars simultaneously Add tests for Eidos processing and Influence Statements
1 participant