Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some CLASSPATH handling to allow more conveniently using REACH and Eidos and allow testing both on Travis. REACHPATH and EIDOSPATH point to the JAR file of each system. These two paths can either be on the CLASSPATH set by the user, or, if not on the CLASSPATH, the right one is added to the CLASSPATH in the respective reach_reader.py or eidos_reader.py.
One change is that REACHPATH now points to the REACH JAR rather than the folder that the REACH JAR is in, this is updated in the various readers. A simultaneous update in indra_deps_docker is ready to be pushed if this is merged.
This fixes #394 to the extent that both readers (and Biopax) can be used with a single fixed setting of environment variables, but due to fundamental limitations in jnius, using both readers in the same session is still not possible (i.e.
from indra.sources import reach, eidos
and then using both wouldn't work). It also fixes #359.