Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MACsec] degradation in ptf tests runtime and logic #5876

Open
AntonHryshchuk opened this issue Jun 27, 2022 · 1 comment
Open

[MACsec] degradation in ptf tests runtime and logic #5876

AntonHryshchuk opened this issue Jun 27, 2022 · 1 comment
Assignees

Comments

@AntonHryshchuk
Copy link
Contributor

Description

By PR #5490 was introduced the degradation of ptf tests runtime and logic.

  1. runtime:
    Before the start of each ptf test, executed the checker for MACsec for each interface.
    This step takes ~1:20 minutes.
    For example the test ecmp/test_fgnhg.py:
    Previously runtime of the test was ~24 minutes.
    Now, the test terminated in our regression with a timeout of 1h. Where more than 30 times called the ptf test. It means that more than 30*1:20 =40 minutes from 1 hour we lost on MAcsec checker.
20:51:01 ptf.create_macsec_info                   L0043 INFO   | MACsec isn't enabled on the port Ethernet180 
20:51:03 ptf.create_macsec_info                   L0043 INFO   | MACsec isn't enabled on the port Ethernet8 
20:51:04 ptf.create_macsec_info                   L0043 INFO   | MACsec isn't enabled on the port Ethernet216 
..............
20:52:20 ptf.create_macsec_info                   L0043 INFO   | MACsec isn't enabled on the port Ethernet20 
20:52:21 ptf.create_macsec_info                   L0043 INFO   | MACsec isn't enabled on the port Ethernet24 
20:52:22 ptf.create_macsec_info                   L0043 INFO   | MACsec isn't enabled on the port Ethernet252 
  1. logic:
    When the test calls to the ptf test, meaning that there will be no more calls to the switch at this time (no additional CLI commands and etc)
    For example the test ecmp/inner_hashing/test_wr_inner_hashing.py :
    The test doing the warm-reboot and running the ptf test in parallel. Not expected that ptf test will start only in 1+ minutes and before will do some actions on the switch, when the switch doing the warm-reboot. As a result we getting the unreachable switch:
        # FIXME - if multiple hosts were involved, should an exception be raised? 
        if cb.unreachable: 
>           raise AnsibleConnectionFailure("Host unreachable", dark=cb.unreachable, contacted=cb.contacted) 
E           AnsibleConnectionFailure: Host unreachable 
@AntonHryshchuk
Copy link
Contributor Author

AntonHryshchuk commented Jun 29, 2022

@Pterosaur please have a look
+@prsunny , @qiluo-msft , @liat-grozovik , @roysr-nv

@Pterosaur Pterosaur self-assigned this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants