Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add check for local_addr in get_bgp_peer #19930

Open
eddieruan-alibaba opened this issue Aug 16, 2024 · 4 comments · May be fixed by sonic-net/sonic-utilities#3565
Open

Need to add check for local_addr in get_bgp_peer #19930

eddieruan-alibaba opened this issue Aug 16, 2024 · 4 comments · May be fixed by sonic-net/sonic-utilities#3565

Comments

@eddieruan-alibaba
Copy link
Collaborator

Description

https://github.com/sonic-net/sonic-utilities/blob/317e649514c9b205849ffb5ea96a6a233e38290c/scripts/ipintutil#L51

In get_bgp_peer(), local_addr is picked mandatory. But local_addr maps to update source config in BGP which is not a mandatory config for a BGP neighbor config.

During #19924 review, @venkatmahalingam suggests to make the change as

if 'local_addr' in data[neighbor_ip]:
local_addr = data[neighbor_ip]['local_addr']
else:
local_addr = ""

Open this issue to track the change.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@gechiang
Copy link
Collaborator

@eddieruan-alibaba not sure what is the ask here. it seems that this was opened as part of another PR review?
Can you clarify more or maybe this should be resolved as part of the mentioned PR?

@eddieruan-alibaba
Copy link
Collaborator Author

@gechiang

Need someone to put the fix in show ip interface command. The diff suggested by @venkatmahalingam is not related to my existing. It is an existing issue which needs to be fixed.

@eddieruan-alibaba eddieruan-alibaba removed their assignment Aug 28, 2024
@gechiang
Copy link
Collaborator

@StormLiangMS , can you help take a look at this one and see if this is something requiring some work and help assign accordingly?
Thanks!

@matofeder
Copy link

Find fix here sonic-net/sonic-utilities#3565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants