You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off, love your package, it's helped me out a lot!
Secondly I was using your package to run some kmeans clustering and I noticed that the types published under the @types/skmeans package are not correct.
Specifically, the skmeans function is typed as returning Data and Data is typed as follows
But centroids: number is not correct. As far as I see the centroids property returned by skmeans returns an array of centroids, so the correct type should be centroids: number[] | number[][]
The text was updated successfully, but these errors were encountered:
Hi,
First off, love your package, it's helped me out a lot!
Secondly I was using your package to run some kmeans clustering and I noticed that the types published under the
@types/skmeans
package are not correct.Specifically, the
skmeans
function is typed as returningData
andData
is typed as followshttps://github.com/adamzerella/DefinitelyTyped/blob/e84211cf43b463bb00759e3156ea7010516ee9b1/types/skmeans/index.d.ts#L11
But
centroids: number
is not correct. As far as I see thecentroids
property returned by skmeans returns an array of centroids, so the correct type should becentroids: number[] | number[][]
The text was updated successfully, but these errors were encountered: