Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix active detection for url's containing international characters #484

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

rvlzzr
Copy link
Contributor

@rvlzzr rvlzzr commented Oct 1, 2024

The active/inactive classes don't apply correctly for URL's containing international characters, as the location is URL-encoded while the path passed to the component is not. This is one way to make it work, the alternatives being to encode the path coming in, or to decode the location everywhere (which I would personally like to see but would be a larger change). Not sure which is preferred.

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 706d569

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
Copy link
Member

I'm not sure which is prefered either. I feel like we tried some encode/decode stuff previously and it got us in trouble. But I am definitely open to finding the right solution. This is easy enough for now but I do wonder if we will find more issues unless we solve this systematically.

@ryansolid ryansolid merged commit e09f638 into solidjs:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants