Merge pull request #481 from CirnoV/patch-1

Fix scrollToHash to handle hashes starting with a number
solidjs · Sep 25, 2024 · cf0ebbf · cf0ebbf
2 parents 626c224 + c61231d
commit cf0ebbf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/hungry-trees-explode.md b/.changeset/hungry-trees-explode.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/router": patch
+---
+
+Fix scrollToHash to handle hashes starting with a number
diff --git a/src/routers/createRouter.ts b/src/routers/createRouter.ts
@@ -65,7 +65,7 @@ export function bindEvent(target: EventTarget, type: string, handler: EventListe
 }
 
 export function scrollToHash(hash: string, fallbackTop?: boolean) {
-  const el = querySelector(`#${hash}`);
+  const el = querySelector(`#${hash}`) ?? document.getElementById(hash);
   if (el) {
     el.scrollIntoView();
   } else if (fallbackTop) {