-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qpp::measure causes Eigen assert #132
Comments
Thanks! Good catch. I'll incorporate the fix into the current dev branch (where I'm fixing the other issue), so no need for a PR for this one. |
@antoine-bussy Fixed on dev branch. In fact, there's no need for that resize second argument, so simply defining |
Thanks! I uncovered another "bug" stemming from my PR #110.
Point 2 is fine as long as users stick to
@vsoftco What do you think? |
@antoine-bussy Yes, I bumped into that (when testing your code). I think the latest solution is the most straightforward, and least intrusive. |
Hi,
qpp::measure
causes the following Eigen assert:I've reproduced it with the following test: antoine-bussy@b873e7e
and fixed it this way: antoine-bussy@36b0343
The bug is that
outstates
is being initialized with square matrices, even though it stores vectors in this use case.Do you want me to submit a PR?
The text was updated successfully, but these errors were encountered: