-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Run all animations on the same thread to prevent out of sync updates #6277
Draft
MatiPl01
wants to merge
3
commits into
main
Choose a base branch
from
@matipl01/fix-out-of-sync-animations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
commented
Jul 16, 2024
@@ -1,19 +1,131 @@ | |||
import { Text, StyleSheet, View } from 'react-native'; | |||
import type { LayoutChangeEvent, StyleProp, ViewStyle } from 'react-native'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert changes in this example file when we decide to merge this PR
Hi! I've faced crash issues using this patch and react-native-svg.
Do you have any idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the logic we use to execute animations. It executes all animations on the native thread instead of the UI and native thread to prevent animation synchronization issues. If at least one layout prop animation is detected in the batch, the whole animations batch is executed on the native thread.
It fixes the issue that can be seen only on paper. Fabric works fine as it uses its own logic.
Example recordings
Screen_Recording_20240717_185812_ReanimatedExample.mp4
Screen_Recording_20240717_185915_ReanimatedExample.mp4
Test plan
Remarks
Performance impact must be assessed before merging this PR. It moves the execution of all updated to a single thread, which may not be that efficient compared to running updates on 2 threads (native and UI).