-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Bug】Modal displays incorrectly if use reanimated #6035
Comments
same problem, Fatal defect,please fix this as soon as possible |
@rabbitmouse Hello, I ran your repro and it worked perfectly for me. Definitely one thing I can suggest you is to run: Screen.Recording.2024-05-21.at.15.13.24.mov |
@szydlovsky hi, I think you are running in debug mode. This bug will only exist in release mode. iOS: Please modify the running mode in xcode scheme Android: Please refer to the steps below and install apk into your device cd ModalBugDemo/ |
hey @rabbitmouse, I have created a yarn-based repo using exact same versions (RN 0.73.6, REA 3.6.2, release mode) - and the bug isn't there. Same happens when I use your repro code in the Reanimated Example app - there are no bugs whatsoever. Please take a look at the repo: https://github.com/szydlovsky/modalrepro, there has to be something wrong with your setup then. (With yarn you have to run: |
Thank you for your reply! @szydlovsky Modal is normal in the old architecture, but problems will occur in the release environment of the new architecture. Please modify app.json to enable the new architecture. like this code below "plugins": [
"expo-router",
[
"expo-build-properties",
{
"ios": {
"newArchEnabled": true,
"flipper": true
},
"android": {
"newArchEnabled": true
}
}
],
], |
This bug will only appear when the new architecture + release mode. and i use expo to create the demo.
Please refer to my process and try again, thank you very much! 😭 @szydlovsky |
Same issue |
Description
Our project uses the new ReactNative architecture. In the release environment, when the page contains both reanimted and modal, the modal display will be abnormal, and the sub-nodes in the modal will be displayed in the upper left corner.
bugvideo.mov
Steps to reproduce
Snack or a link to a repository
https://github.com/rabbitmouse/ModalBugDemo
Reanimated version
3.11.0
React Native version
0.73.6
Platforms
Android, iOS
JavaScript runtime
Hermes
Workflow
React Native
Architecture
Fabric (New Architecture)
Build type
Release app & production bundle
Device
Real device
Device model
iphone12, Galaxy S22
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: