Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 다른 페이지로 라우팅 되었을 때 스크롤바가 맨위로 안가는 버그 수정 #39

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

minani-0621
Copy link
Contributor

✅구현사항

  • 새로운 path로 이동했을 때 스크롤바가 맨위로 가도록 Router.tsx 로직 수정

@minani-0621 minani-0621 added the Fix fix label Aug 13, 2024
Copy link
Collaborator

@Dunkkkk Dunkkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귿!

@@ -35,6 +35,7 @@ const Router: FC<RouterProps> = ({ children }) => {
window.history.pushState({}, "", newPath);
}
setPath(newPath);
window.scrollTo(0, 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

같이 이게 어떻게 왜 실행되는지 한번 공부해봅시다!

@Dunkkkk Dunkkkk merged commit 25e797c into develop Aug 13, 2024
1 check passed
@Dunkkkk Dunkkkk deleted the hotfix/Router branch August 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants