Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 숨은그림찾기 종료 후 보이는 결과 페이지 구현 및 라우터 수정 #16

Merged
merged 8 commits into from
Aug 8, 2024
Merged

[Feat] 숨은그림찾기 종료 후 보이는 결과 페이지 구현 및 라우터 수정 #16

merged 8 commits into from
Aug 8, 2024

Conversation

Dunkkkk
Copy link
Collaborator

@Dunkkkk Dunkkkk commented Aug 8, 2024

구현 사항

  • 숨은그림 찾기 종료 후 나오는 결과페이지 Page 및 로직 구현
  • Hyunouter에 있는 조건부 랜더링 로직 삭제
  • Hyunouter에 path 수정하지 않고 page 이동 시키는 로직 추가

구현 상세 사항

<Link to="...."  isPathChange={false}>

위에 처럼 pathChange를 false하면 history API를 부르지 않고 페이지만 변경한다.

minani-0621
minani-0621 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@minani-0621 minani-0621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셧슴돠~

@minani-0621 minani-0621 merged commit 7494bc4 into develop Aug 8, 2024
@minani-0621 minani-0621 deleted the CC-128 branch August 8, 2024 08:23
@minani-0621 minani-0621 added the Feat New feature label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minani-0621 minani-0621 minani-0621 approved these changes

Assignees
No one assigned
Labels
Feat New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunkkkk @minani-0621