-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaCUDA] Compilation error fix (CudaStandardTetrahedralFEMForceField.cu) #991
[SofaCUDA] Compilation error fix (CudaStandardTetrahedralFEMForceField.cu) #991
Conversation
…A and SOFACUDA_DOUBLE are enabled, CudaStandardTetrahedralFEMForceField.cu try to be compiled through NVCC (Nvidia compiler). It was leading to a compile error because of 2 missing function prototypes in the .cu file. This commit fixes the issue. Compilation was tested on Fedora 29 with CUDA Toolkit v10.1
Congrats for your first PR @Ant0nin 👏 |
From SOFA-dev meeting: we had a hard time understanding why it did not compile with CUDA_DOUBLE in the first place. Could you explain why? |
hello @Ant0nin , are you speaking about the option: my version with SOFACUDA_DOUBLE activated compile on windows 10 with recent cudaToolkit. |
@guparan @epernod , I just tested the compilation again (without my patch) and I realized that SOFACUDA_DOUBLE has nothing to do with this issue, I was wrong about that. On my setup, the compilation does not works regardless of the SOFACUDA_DOUBLE option. I'm a bit surprized it works on your side. Here are information on my setup: And here are the output errors from ninja:
|
I'm using sofaCUDA on windows. Will try to install it on my ubuntu 18.04 |
Add a comment
Compilation error fix. When CMake variables PLUGIN_SOFACUDA and SOFACUDA_DOUBLE are enabled, CudaStandardTetrahedralFEMForceField.cu try to be compiled through NVCC (Nvidia compiler). It was leading to a compile error because of 2 missing function prototypes in the .cu file. This commit fixes the issue. Compilation was tested on my side on Fedora 29 with CUDA Toolkit v10.1
This PR:
Reviewers will merge only if all these checks are true.