Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaGeneralLoader] Compute subElement by default for Gmsh format #986

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Apr 10, 2019

This bug just pop up again in #967 and was referenced in issue #631
Several Gmsh file have non coherent topology information, for example Triangulation with edges on the border only. This mess up information feeding the topology container.

If this behavior is wanted, use <MeshGmshLoader createSubelements="0" /> and be sure to link the different topology buffer data to the appropriate components.
For example:

<MeshGmshLoader name="loader" createSubelements="0" />

<Node name="triangulation" >
   <TriangleSetTopologyContainer name="tri_topo" triangles="@../loader.triangles" />
</Node>

<Node name="border" >
   <TriangleSetTopologyContainer name="edge_topo" edges="@../loader.edges" />
</Node>

fixes #631


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Apr 10, 2019
@epernod epernod self-assigned this Apr 10, 2019
@epernod
Copy link
Contributor Author

epernod commented Apr 10, 2019

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 17, 2019
@epernod epernod merged commit 9ca85be into sofa-framework:master Apr 17, 2019
@epernod epernod deleted the loader_fix branch April 17, 2019 20:24
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
alxbilger pushed a commit to alxbilger/sofa that referenced this pull request Oct 27, 2023
[SofaGeneralLoader] Compute subElement by default for Gmsh format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshGmshLoader should create all edges
2 participants