Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaPython] FIX allow the derivTypeFromParentValue to work with node. #984

Merged
merged 2 commits into from
Apr 18, 2019
Merged

[SofaPython] FIX allow the derivTypeFromParentValue to work with node. #984

merged 2 commits into from
Apr 18, 2019

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Apr 5, 2019 •
edited
Loading

Currently only object are supported by this function which is not consistant
with the rest of Sofa.

Eg of consequence you cannot make a PythonScriptDataEngine connecting
data field from nodes (as only object are possible).

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
[SofaPython] FIX allow the derivTypeFromParentValue to work with node…
9aab799 
… and object.

Currently only object are supported by this function which is not consistant
with the rest of Sofa.

Eg of consequence you cannot make a PythonScriptDataEngine connecting
data field from nodes (as only object are possible).

Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr>
@damienmarchal damienmarchal added issue: bug (minor) Bug affecting only some users or with no major impact on the framework pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Apr 5, 2019
@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed issue: bug (minor) Bug affecting only some users or with no major impact on the framework pr: status to review To notify reviewers to review this pull-request labels Apr 10, 2019
@damienmarchal
Copy link
Contributor Author

Thanks bruno for providing the missing code.

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Apr 15, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 17, 2019
@marques-bruno marques-bruno merged commit 6dedeef into sofa-framework:master Apr 18, 2019
@damienmarchal damienmarchal deleted the fixAddSupportForNodeInPSDE branch April 24, 2019 22:59
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
3 participants
@damienmarchal @guparan @marques-bruno