-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaKernel] FIX in TetrahedronFEMForceField & TetrahedronSetTopologyAlgorithm #973
Conversation
The segfault happens when the component is located in a node without a topology and a mechanical object. Then the 'draw' function is crashing.
…MForceField The component was searching the topology in the context which was: - implicit - constraining the organization of components the scene graph. To solve this I added a SingleLink that allows to specify the topology. If the link is not set then the existing behavior is used.
[ci-build][with-all-tests] |
there are new tests failure:
|
The checked ifdef is not valid and not following the SOFA way of doing things. So I fixed it.
Thank for the reviewed.
So i moved the EdgeSet into the same node as the topology. So the error does not pop up. |
yes, a EdgeSetGeometryAlgorithms should not be inside a node without mechanicalObject nor a topology container (I know a lot of check are still missing :( ).
|
… mechanicalObject
Hi, here is the content:
[SofaKernel] FIX segfault in TetrahedronSetGeometryAlgorithms
The segfault happens when the component is located in a node without
a topology and a mechanical object. Then the 'draw' function is crashing.
[SofaKernel] ADD a link to manually set the topology in TetrahedronFEMForceField
The component was searching the topology in the context which was:
To solve this I added a SingleLink that allows to specify the topology.
If the link is not set then the existing behavior is used.
This PR:
Reviewers will merge only if all these checks are true.