-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivate Modeler by default, since it is deprecated #972
Conversation
@@ -7,9 +7,7 @@ if(NOT Qt5Core_FOUND) | |||
set(SOFA_HAVE_QT_LIBRARIES 0) | |||
endif() | |||
|
|||
if(SOFA_HAVE_QT_LIBRARIES) | |||
sofa_add_application(Modeler Modeler OFF) | |||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? I would have kept the condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did too at first, but it's a bit weird to do a check required for activation to then deactivate the thing. If the modeler require qt, then it should check for qt itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the modeler require qt, then it should check for qt itself.
I agree with that but you can't just remove the condition then, you should move it to Modeler's CMakeLists (and fail or warn+return if false).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modeler does find_package(Qt5 COMPONENTS Core QUIET)
Maybe just change that to REQUIRED
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with that 👍
This PR:
Reviewers will merge only if all these checks are true.