Deactivate Modeler by default, since it is deprecated #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaugry
added
the
pr: status to review
guparan
reviewed
Mar 27, 2019
| @@ -7,9 +7,7 @@ if(NOT Qt5Core_FOUND) | |||
| set(SOFA_HAVE_QT_LIBRARIES 0) | |||
| endif() | |||
|
|
|||
| if(SOFA_HAVE_QT_LIBRARIES) | |||
| sofa_add_application(Modeler Modeler OFF) | |||
| endif() | |||
There was a problem hiding this comment.
Why? I would have kept the condition.
There was a problem hiding this comment.
I did too at first, but it's a bit weird to do a check required for activation to then deactivate the thing. If the modeler require qt, then it should check for qt itself.
There was a problem hiding this comment.
If the modeler require qt, then it should check for qt itself.
I agree with that but you can't just remove the condition then, you should move it to Modeler's CMakeLists (and fail or warn+return if false).
There was a problem hiding this comment.
Modeler does find_package(Qt5 COMPONENTS Core QUIET)
Maybe just change that to REQUIRED ?
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Reviewers will merge only if all these checks are true.