Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] FIX: A few fix to compile on Mac OSX Xcode 9 and Linux gcc 7.3.0 #969

Merged
merged 7 commits into from
Mar 28, 2019
Merged

[SofaKernel] FIX: A few fix to compile on Mac OSX Xcode 9 and Linux gcc 7.3.0 #969

merged 7 commits into from
Mar 28, 2019

Conversation

fspadoni
Copy link
Contributor

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Mar 18, 2019
@epernod epernod changed the title [FIX] A few fix to compile on Mac OSX Xcode 9 and Linux gcc 7.3.0 [SofaKernel] FIX: A few fix to compile on Mac OSX Xcode 9 and Linux gcc 7.3.0 Mar 18, 2019
tgaugry
tgaugry reviewed Mar 20, 2019
View reviewed changes
SofaKernel/framework/sofa/simulation/CMakeLists.txt Outdated

# is this a compiler/linker version specific problem?
if(CMAKE_SYSTEM_NAME STREQUAL Linux)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread" )
Copy link
Contributor

@tgaugry tgaugry Mar 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_compile_options

Copy link
Contributor Author

@fspadoni fspadoni Mar 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-pthread should be passed as linking options:
target_link_options(${PROJECT_NAME} PUBLIC "-pthread")
This doesn't work because the target_link_options is available only starting from CMake 3.13

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Mar 20, 2019
@fspadoni fspadoni mentioned this pull request Mar 20, 2019
Closed
6 tasks
@fspadoni fspadoni added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Mar 27, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 27, 2019
@epernod epernod merged commit 9cbb775 into sofa-framework:master Mar 28, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan left review comments

@tgaugry tgaugry tgaugry left review comments

Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
4 participants
@fspadoni @guparan @tgaugry @epernod