Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaPython][SofaGuiQt] REMOVE: public export of target SofaExporter #963

Merged

Conversation

marques-bruno
Copy link
Member

SofaExporter was a linked to SofaPython & SofaGuiQt under the PUBLIC scope while that dependency is internal & should not be exposed publicly


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@marques-bruno marques-bruno added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Mar 11, 2019
@marques-bruno marques-bruno self-assigned this Mar 11, 2019
@marques-bruno
Copy link
Member Author

FYI I didn't find any other PUBLIC link of SofaExporter in sofa's CMakeLists

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 13, 2019
@epernod epernod merged commit d7e2846 into sofa-framework:master Mar 15, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@damienmarchal damienmarchal deleted the remove_SofaExporterTarget branch August 25, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants