Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaSimulationCore] FIX CollisionVisitor::processCollisionPipeline #962

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[SofaSimulationCore] FIX CollisionVisitor::processCollisionPipeline #962

merged 1 commit into from
Mar 12, 2019

Conversation

courtecuisse
Copy link
Contributor

@courtecuisse courtecuisse commented Mar 11, 2019 •
edited by damienmarchal
Loading

Fix bug in collision visitor.
Check if the narrow phase is null before calling getNarrowPhaseDetection

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 11, 2019
@damienmarchal
Copy link
Contributor

The CI is down, but to me this is ok. So I take the resposability of merging it :)

@damienmarchal damienmarchal merged commit fce78c3 into sofa-framework:master Mar 12, 2019
@damienmarchal damienmarchal mentioned this pull request Mar 28, 2019
Closed
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@guparan guparan changed the title fix collision visitor i.e. check if narrow phase is null before calli… [SofaSimulationCore] FIX CollisionVisitor::processCollisionPipeline Jun 20, 2019
@courtecuisse courtecuisse deleted the fixcollision branch September 16, 2019 08:17
@courtecuisse courtecuisse restored the fixcollision branch September 16, 2019 08:17
@courtecuisse courtecuisse deleted the fixcollision branch September 16, 2019 08:18
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
5 participants
@courtecuisse @damienmarchal @guparan @hugtalbot @epernod