-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cgal plugin] Fix windows cmake dll path and add a scene example #958
Conversation
…if not add option to set it to search for cgal dlls.
So I tried to play a bit with CGALPlugin and realized we can use CGAL in header-only mode. So, why should we copy some dlls? EDIT: here is a patch to try my changes in this branch: cgal-plugin_fix.patch.txt |
Did you have some time to test my patch @epernod ? |
ok, it works if I don't build cgal, so in header only (only execute cgal-setup.exe, no visual build after this step) |
Header only usage should work even if CGAL has been built before. I will try to force header_only, there is a CMake variable for that in CGAL. |
@guparan do you remember what is the status of CGal plugin config on windows? |
Not sure this is the good way to do it with cmake findCGal but otherwise the dll are not linked (if not on env_path)
Add a quick scene test for cgal without image plugin.
This PR:
Reviewers will merge only if all these checks are true.