Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Some small changes in debug topology drawing #952

Merged
merged 4 commits into from
Mar 6, 2019
Merged

[SofaKernel] Some small changes in debug topology drawing #952

merged 4 commits into from
Mar 6, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Mar 4, 2019 •
edited
Loading

  • Add: Display border of tetrahedra,
  • Update: draw methods to check the number of elements and reduce the number of indent in code.
  • Add: handle wireframe for triangles and quads
  • Fix: Bad lighting disable without corresponding enable in drawTools

simpletesselatedtetratopologicalmapping_00000001

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod self-assigned this Mar 4, 2019
@epernod epernod added pr: status to review To notify reviewers to review this pull-request enhancement About a possible enhancement labels Mar 4, 2019
@epernod
Copy link
Contributor Author

epernod commented Mar 4, 2019

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed pr: fast merge Minor change that can be merged without waiting for the 7 review days and removed pr: status to review To notify reviewers to review this pull-request labels Mar 6, 2019
@guparan guparan merged commit 879a05d into sofa-framework:master Mar 6, 2019
@epernod epernod deleted the topo_draw branch May 4, 2019 16:11
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees

@epernod epernod

Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @hugtalbot @guparan