Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaDeformable] FIX issue928 #942

Merged
merged 2 commits into from
Mar 2, 2019
Merged

[SofaDeformable] FIX issue928 #942

merged 2 commits into from
Mar 2, 2019

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Feb 22, 2019 •
edited
Loading

This PR FIX Issue #928 and add basic tests on RestShapeSpringsForceField.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added the pr: fix Fix a bug label Feb 22, 2019
@damienmarchal
[SofaDeformable] FIX bug when angleStiffness.size() < stiffness.size()
48cc214 
In this situation the component just crash Sofa.
@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Feb 24, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 27, 2019
@damienmarchal
Copy link
Contributor Author

[ci-build][with-scene-tests]

@epernod epernod merged commit f1b1522 into sofa-framework:master Mar 2, 2019
@damienmarchal damienmarchal deleted the fixIssue928 branch April 24, 2019 22:59
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@alxbilger alxbilger mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
3 participants
@damienmarchal @guparan @epernod