Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaMeshCollision] Fix TriangleModel to handle topology changes #903

Merged
merged 11 commits into from
Feb 13, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jan 22, 2019

Fix crash when removing triangles in scene using TriangleModel component.

Clean and comment the class while undusting it (sorry hard to read the diff)

  • remove serr/sout
  • change all protected members prefix
  • rewritte init and updateFromTopology methods
  • Remove the handleTopologyChange method. As this class use directly the topology buffers, no need neither for TopologyData. Just check the topology revision and update the component if topology has changed.
  • Update RemovingTrianglesProcess and AddingTrianglesProcess tests scenes to test the TriangleModel

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jan 22, 2019
@epernod epernod self-assigned this Jan 22, 2019
@epernod
Copy link
Contributor Author

epernod commented Jan 22, 2019

[ci-build][with-all-tests]

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jan 23, 2019
…te mesh component when revision has changed.
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jan 24, 2019
@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jan 30, 2019
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Feb 8, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 13, 2019
@damienmarchal damienmarchal merged commit 963b5dd into sofa-framework:master Feb 13, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants