-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaMeshCollision] Fix TriangleModel to handle topology changes #903
Merged
damienmarchal
merged 11 commits into
sofa-framework:master
from
epernod:topology_changes_fix
Feb 13, 2019
Merged
[SofaMeshCollision] Fix TriangleModel to handle topology changes #903
damienmarchal
merged 11 commits into
sofa-framework:master
from
epernod:topology_changes_fix
Feb 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gleModel. As this class use directly the topology buffers, no need neither for TopologyData. Just check the topology revision and update the component if topology has changed.
epernod
added
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
pr: clean
Cleaning the code
labels
Jan 22, 2019
[ci-build][with-all-tests] |
guparan
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jan 23, 2019
…te mesh component when revision has changed.
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jan 24, 2019
guparan
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jan 30, 2019
…triangle buffer and *buffer
…error if no topology is provided.
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Feb 8, 2019
…s mixing quads and triangles.
guparan
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: clean
Cleaning the code
pr: fix
Fix a bug
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when removing triangles in scene using TriangleModel component.
Clean and comment the class while undusting it (sorry hard to read the diff)
This PR:
Reviewers will merge only if all these checks are true.