Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geomagic] FIX compilation error in Geomagic plugin with removal of SOFA_FLOAT/DOUBLE #898

Merged
merged 1 commit into from
Jan 18, 2019
Merged

[Geomagic] FIX compilation error in Geomagic plugin with removal of SOFA_FLOAT/DOUBLE #898

merged 1 commit into from
Jan 18, 2019

Conversation

vmagno
Copy link
Contributor

@vmagno vmagno commented Jan 16, 2019

Changed the mixed-precision mappings for generic ones. This fixes issue #892 (and is related to #893)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@vmagno vmagno added the pr: fix Fix a bug label Jan 16, 2019
@hugtalbot
Copy link
Contributor

Cool merci Vincent !!

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Jan 16, 2019
@damienmarchal
Copy link
Contributor

Hi Vincent,

Thanks a lot for this fix.

@damienmarchal damienmarchal added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 18, 2019
@damienmarchal
Copy link
Contributor

@hugtalbot to me it is ready to fast-merge.

@epernod
Copy link
Contributor

epernod commented Jan 18, 2019

I ++ approve and merge it!

@epernod epernod merged commit 3e4ed76 into sofa-framework:master Jan 18, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
5 participants
@vmagno @hugtalbot @damienmarchal @epernod @guparan