[all] Sofa defrost sprint week2 #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindThreads.cmake collide with the FindThreads.cmake provided in boost. (I don't know if any module in our codebase do find_package(FindThread))
damienmarchal
added
pr: status to review
My usuall cleaning PR (when I put my brain in automated mode to): - move some code from .h to .cpp - use msg_* API - remove commented code - group protected/public/ in .h - add override on virtual constructor - replace some NULL by nullptr (but I would like someone try clang-tidy to do that All that is very minor and shouldn't break anything.
damienmarchal
force-pushed
the
sofa_defrostSprintWeek2
branch
from
59b0dc7
to
c24893f
Compare
| if (!isActive()) | ||
| return; | ||
| if (mstate) | ||
| { | ||
| // serr << "ProjectiveConstraintSet<DataTypes>::projectResponse(const MechanicalParams* mparams, MultiVecDerivId dxId) " << this->getName() << " has mstate " << sendl; | ||
|
|
||
| projectResponse(mparams, *dxId[mstate.get(mparams)].write()); | ||
| } | ||
| else serr << "ProjectiveConstraintSet<DataTypes>::projectResponse(const MechanicalParams* mparams, MultiVecDerivId dxId), no mstate for " << this->getName() << sendl; |
There was a problem hiding this comment.
clean: replacing serr with msg_*
marques-bruno
added
pr: status ready
| BaseConstraintCorrection::BaseConstraintCorrection(){} | ||
| BaseConstraintCorrection::~BaseConstraintCorrection(){} | ||
|
|
||
| void BaseConstraintCorrection::rebuildSystem(double /*massFactor*/, double /*forceFactor*/){} |
There was a problem hiding this comment.
minor comment: use SOFA_UNUSED instead of commenting out variable names
|
[ci-build][with-scene-tests][with-regression-tests] |
hugtalbot
reviewed
Jan 21, 2019
| obj->parse(arg); | ||
| } | ||
| virtual void init(void) override; | ||
| virtual void handleEvent( core::objectmodel::Event* event ) override; |
There was a problem hiding this comment.
Why setting those as private? @damienmarchal
There was a problem hiding this comment.
ok I will correct it in #899
hugtalbot
reviewed
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
Nothing should be broken with the change (expect your branches with a lot of divergence)
This PR:
Reviewers will merge only if all these checks are true.