-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Sofa defrost sprint week2 #884
[all] Sofa defrost sprint week2 #884
Conversation
FindThreads.cmake collide with the FindThreads.cmake provided in boost. (I don't know if any module in our codebase do find_package(FindThread))
My usuall cleaning PR (when I put my brain in automated mode to): - move some code from .h to .cpp - use msg_* API - remove commented code - group protected/public/ in .h - add override on virtual constructor - replace some NULL by nullptr (but I would like someone try clang-tidy to do that All that is very minor and shouldn't break anything.
59b0dc7
to
c24893f
Compare
if (!isActive()) | ||
return; | ||
if (mstate) | ||
{ | ||
// serr << "ProjectiveConstraintSet<DataTypes>::projectResponse(const MechanicalParams* mparams, MultiVecDerivId dxId) " << this->getName() << " has mstate " << sendl; | ||
|
||
projectResponse(mparams, *dxId[mstate.get(mparams)].write()); | ||
} | ||
else serr << "ProjectiveConstraintSet<DataTypes>::projectResponse(const MechanicalParams* mparams, MultiVecDerivId dxId), no mstate for " << this->getName() << sendl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean: replacing serr with msg_*
BaseConstraintCorrection::BaseConstraintCorrection(){} | ||
BaseConstraintCorrection::~BaseConstraintCorrection(){} | ||
|
||
void BaseConstraintCorrection::rebuildSystem(double /*massFactor*/, double /*forceFactor*/){} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment: use SOFA_UNUSED instead of commenting out variable names
[ci-build][with-scene-tests][with-regression-tests] |
obj->parse(arg); | ||
} | ||
virtual void init(void) override; | ||
virtual void handleEvent( core::objectmodel::Event* event ) override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why setting those as private? @damienmarchal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I will correct it in #899
CHANGELOG:
Nothing should be broken with the change (expect your branches with a lot of divergence)
This PR:
Reviewers will merge only if all these checks are true.