Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] EDIT Sofa icons #881

Merged
merged 1 commit into from
Jan 9, 2019
Merged

[Icons] EDIT Sofa icons #881

merged 1 commit into from
Jan 9, 2019

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Jan 9, 2019 •
edited
Loading

I think it's time to update our old icons for v18.12 😉

SOFA.png
SOFA

MODELER.png
MODELER

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jan 9, 2019
@hugtalbot hugtalbot added the pr: status ready Approved a pull-request, ready to be squashed label Jan 9, 2019
@hugtalbot hugtalbot merged commit 0057a0c into sofa-framework:master Jan 9, 2019
guparan pushed a commit that referenced this pull request Jan 9, 2019
@hugtalbot @guparan
Merge pull request #881 from guparan/new_icons
69fdd14 
[Icons] EDIT Sofa icons
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @hugtalbot