-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaKernel] Minor code refactor in BaseData & new StringUtils functions. #860
Merged
marques-bruno
merged 3 commits into
sofa-framework:master
from
SofaDefrost:sofa_mergeCodeWithDefaultParam
Jan 16, 2019
Merged
[SofaKernel] Minor code refactor in BaseData & new StringUtils functions. #860
marques-bruno
merged 3 commits into
sofa-framework:master
from
SofaDefrost:sofa_mergeCodeWithDefaultParam
Jan 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: status to review
To notify reviewers to review this pull-request
labels
Dec 11, 2018
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
December 13, 2018 14:35
3facf42
to
a11c83a
Compare
@damienmarchal Isn't this PR independent from #859? I can remove ca88a83 from it. |
6 tasks
damienmarchal
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Dec 19, 2018
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
2 times, most recently
from
January 8, 2019 13:55
3facf42
to
8a8a560
Compare
damienmarchal
changed the title
[SofaKernel] merge code with default param
[SofaKernel] Minor code refactor in BaseData & new StringUtils functions.
Jan 8, 2019
damienmarchal
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jan 8, 2019
guparan
reviewed
Jan 9, 2019
[ci-build][with-scene-tests] |
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
January 9, 2019 21:19
bffbd51
to
9897858
Compare
Can someone review this ? |
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
January 11, 2019 10:21
9897858
to
7cb6b94
Compare
…vector. So it look taste like python instead of having to write complex stl algorithms.
…m BaseObjectDescriptions.
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
January 11, 2019 10:26
7cb6b94
to
9b8cec6
Compare
marques-bruno
approved these changes
Jan 14, 2019
guparan
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: clean
Cleaning the code
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two change needed by the SofaPython3 plugin.
In BaseData Some method have two version, one without arguments the other with an ExecParm. In pybind11 we need to differentiate explicitely the two version making the code more complex. As I see no good reason why to keep the two version in Sofa I merged these two into one by using a default param = nullptr.
I have added a join/split function in the StringUtils class.
In SimpleAPI I found allowing BaseObjectDescription useful to create object and node. So I added new functions.
This PR:
Reviewers will merge only if all these checks are true.