[SofaKernel] Minor code refactor in BaseData & new StringUtils functions. #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: fast merge
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
3facf42
to
a11c83a
Compare
|
@damienmarchal Isn't this PR independent from #859? I can remove ca88a83 from it. |
6 tasks
damienmarchal
added
pr: status wip
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
2 times, most recently
from
3facf42
to
8a8a560
Compare
damienmarchal
changed the title
damienmarchal
added
pr: status to review
guparan
reviewed
Jan 9, 2019
|
[ci-build][with-scene-tests] |
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
bffbd51
to
9897858
Compare
|
Can someone review this ? |
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
9897858
to
7cb6b94
Compare
…vector. So it look taste like python instead of having to write complex stl algorithms.
…m BaseObjectDescriptions.
damienmarchal
force-pushed
the
sofa_mergeCodeWithDefaultParam
branch
from
7cb6b94
to
9b8cec6
Compare
marques-bruno
approved these changes
Jan 14, 2019
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two change needed by the SofaPython3 plugin.
In BaseData Some method have two version, one without arguments the other with an ExecParm. In pybind11 we need to differentiate explicitely the two version making the code more complex. As I see no good reason why to keep the two version in Sofa I merged these two into one by using a default param = nullptr.
I have added a join/split function in the StringUtils class.
In SimpleAPI I found allowing BaseObjectDescription useful to create object and node. So I added new functions.
This PR:
Reviewers will merge only if all these checks are true.