-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaRigid] Clean JointSpringFF #850
[SofaRigid] Clean JointSpringFF #850
Conversation
[ci-build][with-scene-tests] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I get it you move the definition of a spring inside a class and use it inside JointSpringFF ?
Do you think this can be factorized with other springFF?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also could you check the CI, several tests are broken:
https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-850/CI_CONFIG=ubuntu_gcc-5.4,CI_PLUGINS=options,CI_TYPE=release/2/warnings4Result/
https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-850/CI_CONFIG=ubuntu_gcc-5.4,CI_PLUGINS=options,CI_TYPE=release/2/ warnings4Result/package.-377079774/ + see BUILD_URL/artifact/parent_dir/build/scene-tests/examples/Components/constraint/FixedLMConstraint.scn/output.txt = |
[ci-build][with-scene-tests] |
[ci-build][with-scene-tests][with-regression-tests] |
Did this one ready ? What is missing ? |
I think it's just that it's never been changed back to to_review after @VannesteFelix's changes.. |
Ready! |
Cleaning of JointSpringFF according to SOFA conventions
This PR:
Reviewers will merge only if all these checks are true.