[SofaMiscMapping] Clean DeformableOnRigidFrameMapping #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e commented code, remove useless includes)
olivier-goury
added
pr: status to review
|
[ci-build][with-all-tests] |
epernod
reviewed
Dec 4, 2018
| @@ -104,7 +87,7 @@ void DeformableOnRigidFrameMapping<TIn, TInRoot, TOut>::init() | |||
| if(!this->getFromModels2().empty()) | |||
| { | |||
| m_fromRootModel = this->getFromModels2()[0]; | |||
| sout << "Root Model found : Name = " << m_fromRootModel->getName() << sendl; | |||
| sout << "Root Model found : Name = " << m_fromRootModel->getName() ; | |||
There was a problem hiding this comment.
Indeed, thanks!
| // } | ||
| //} | ||
|
|
||
| /* |
There was a problem hiding this comment.
what a huge commented code!
| m_fromModel->getContext()->get(m_fromRootModel, core::objectmodel::BaseContext::SearchUp); | ||
|
|
||
|
|
||
| // (30-11-2018, Olivier Goury): Not implemented yet. Someone want to do it? |
epernod
approved these changes
Dec 5, 2018
guparan
added
pr: status ready
guparan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to clean up DeformableOnRigidFrameMapping, during DEFROST team coding friday.
This PR:
Reviewers will merge only if all these checks are true.