-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaMiscMapping] Clean DeformableOnRigidFrameMapping #848
Conversation
…e commented code, remove useless includes)
[ci-build][with-all-tests] |
@@ -104,7 +87,7 @@ void DeformableOnRigidFrameMapping<TIn, TInRoot, TOut>::init() | |||
if(!this->getFromModels2().empty()) | |||
{ | |||
m_fromRootModel = this->getFromModels2()[0]; | |||
sout << "Root Model found : Name = " << m_fromRootModel->getName() << sendl; | |||
sout << "Root Model found : Name = " << m_fromRootModel->getName() ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks!
// } | ||
//} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a huge commented code!
m_fromModel->getContext()->get(m_fromRootModel, core::objectmodel::BaseContext::SearchUp); | ||
|
||
|
||
// (30-11-2018, Olivier Goury): Not implemented yet. Someone want to do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you put your name...
Simple PR to clean up DeformableOnRigidFrameMapping, during DEFROST team coding friday.
This PR:
Reviewers will merge only if all these checks are true.