Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseCollision] CLEAN CylinderModel #847

Merged
merged 3 commits into from
Dec 12, 2018
Merged

[SofaBaseCollision] CLEAN CylinderModel #847

merged 3 commits into from
Dec 12, 2018

Conversation

ChristianDuriez
Copy link
Contributor

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request labels Dec 4, 2018
@damienmarchal
Copy link
Contributor

[ci-build][with-scene-tests]

@guparan
Copy link
Contributor

guparan commented Dec 5, 2018

Hi @ChristianDuriez could you try renaming all the _* Datas to d_* ? Would be also a nice clean if not too breaking 👍

@epernod
[SofaBaseCollision] change all Data of CylinderModel to have d_ prefi…
ae4dca3 
…x and put them as public. Factorize the constructors.
@epernod
Copy link
Contributor

epernod commented Dec 11, 2018

[ci-build][with-all-tests]

@hugtalbot hugtalbot changed the title Cleaning of CylinderModel [SofaBaseCollision] Cleaning of CylinderModel Dec 12, 2018
@hugtalbot hugtalbot changed the title [SofaBaseCollision] Cleaning of CylinderModel [SofaKernel] Cleaning of CylinderModel Dec 12, 2018
@guparan guparan changed the title [SofaKernel] Cleaning of CylinderModel [SofaBaseCollision] Cleaning of CylinderModel Dec 12, 2018
@guparan guparan changed the title [SofaBaseCollision] Cleaning of CylinderModel [SofaBaseCollision] CLEAN CylinderModel Dec 12, 2018
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 12, 2018
@damienmarchal
Copy link
Contributor

I'm a bit surprised with the test failures;... so i restart
[ci-build][with-all-tests]

@damienmarchal damienmarchal merged commit fd743bf into sofa-framework:master Dec 12, 2018
@guparan guparan added this to the v18.12 milestone Dec 17, 2018
@damienmarchal damienmarchal deleted the CleanCylinderModel branch February 25, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal damienmarchal left review comments

@epernod epernod epernod left review comments

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristianDuriez @damienmarchal @guparan @epernod