[SofaSparseSolver] ADD saveMatrixToFile to SparseLDLSolver #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: status to review
guparan
suggested changes
Dec 5, 2018
|
|
||
| // | ||
| #include <string> | ||
| using namespace std; |
There was a problem hiding this comment.
Please remove the using :-)
guparan
changed the title
guparan
added
pr: status wip
|
[ci-build][with-scene-tests] |
jnbrunet
reviewed
Dec 5, 2018
| void solve (Matrix& M, Vector& x, Vector& b) override ; | ||
| void invert(Matrix& M) override; | ||
| bool addJMInvJtLocal(TMatrix * M, ResMatrixType * result,const JMatrixType * J, double fact) override; | ||
| virtual void solve (Matrix& M, Vector& x, Vector& b) override ; |
There was a problem hiding this comment.
No need for the virtual specifier when override is used.
There was a problem hiding this comment.
We discuss about that at Defrost and we agree with dropping the virtual specifier when override is there, because it is simply less typing.
|
@guparan I made the changes. can you switch the pull request to "to review" ? |
guparan
added
pr: status to review
hugtalbot
reviewed
Dec 12, 2018
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If savingMatrixToFile is set to true, the system matrix is saved during each time step with the name "MatrixInLDL_%04d", where %d is the value of the time.
I added two new input data:
savingFilename
The filename where the matrix is stored can be changed using the input data d_filename.
If it contains "%d", it will keep the previously described behavior, else it will always save in the same file overwriting it.
savingPrecision
The second new input is d_precision. It is the precision with which the matrix will be stored.
These options are useful to save the system matrix from SOFA and read it from another software.
This PR:
Reviewers will merge only if all these checks are true.