Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseLinearSolver] CLEAN GraphScatteredTypes #844

Merged
merged 1 commit into from
Dec 7, 2018
Merged

[SofaBaseLinearSolver] CLEAN GraphScatteredTypes #844

merged 1 commit into from
Dec 7, 2018

Conversation

ChristianDuriez
Copy link
Contributor

@ChristianDuriez ChristianDuriez commented Nov 30, 2018 •
edited by epernod
Loading

Signed-off-by: duriez christian.duriez@inria.fr

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@ChristianDuriez
Cleaning the file GraphScatteredTypes
a536a40 
Signed-off-by: duriez <christian.duriez@inria.fr>
@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 30, 2018
@epernod epernod added pr: fast merge Minor change that can be merged without waiting for the 7 review days and removed pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Dec 4, 2018
@guparan guparan changed the title Cleaning the file GraphScatteredTypes [SofaBaseLinearSolver] CLEAN the file GraphScatteredTypes Dec 5, 2018
@guparan guparan changed the title [SofaBaseLinearSolver] CLEAN the file GraphScatteredTypes [SofaBaseLinearSolver] CLEAN GraphScatteredTypes Dec 5, 2018
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 5, 2018
@epernod epernod merged commit 7232da7 into sofa-framework:master Dec 7, 2018
@guparan guparan added this to the v18.12 milestone Dec 17, 2018
@damienmarchal damienmarchal deleted the cleaningGraphScattered branch January 12, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristianDuriez @epernod @guparan @damienmarchal