Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix scenes having issue with CollisionGroup #821

Merged
merged 1 commit into from
Nov 20, 2018
Merged

[examples] Fix scenes having issue with CollisionGroup #821

merged 1 commit into from
Nov 20, 2018

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Nov 9, 2018 •
edited by guparan
Loading

Chains are behaving normally now.
DefaultCollisionGroup seems to bring a different behavior by solving contact (with penalties) when the all objects are considered as one system

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Nov 9, 2018
@guparan
Copy link
Contributor

guparan commented Nov 14, 2018

@hugtalbot Does that mean we should not use CollisionGroup anymore? Is the component broken?

@guparan
Copy link
Contributor

guparan commented Nov 14, 2018

[ci-build][with-scene-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 20, 2018
@guparan guparan merged commit 32b1bee into sofa-framework:master Nov 20, 2018
@guparan guparan added this to the v18.12 milestone Dec 17, 2018
@guparan guparan changed the title [Scenes] Fix scenes having issue with CollisionGroup [examples] Fix scenes having issue with CollisionGroup Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
2 participants
@hugtalbot @guparan