Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] ADD QtIFW generator + improvements #796

Merged
merged 7 commits into from
Oct 26, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Oct 16, 2018

One step towards continuous delivery in SOFA 🎉

This PR reworks/cleans CPack usage for release packaging and adds a new generator : Qt Installer Framework. Very useful to unify packaging methods, it will be at first used to generate nice installers for Linux.

This means no more .zip package for Linux binaries, unless you want to keep them?

Note: This PR also adds the opening of an URL after installation to ask the user to consider donating to the SOFA project. Do not hesitate to comment if you disagree with this idea.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 16, 2018
@guparan
Copy link
Contributor Author

guparan commented Oct 16, 2018

Packaging started in CI: https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-796/3/

@guparan guparan changed the title [CMake][CPack] ADD QtIFW generator + improvements [CMake] ADD QtIFW generator + improvements Oct 16, 2018
@guparan
Copy link
Contributor Author

guparan commented Oct 22, 2018

[ci-build][with-scene-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 24, 2018
@damienmarchal
Copy link
Contributor

[ci-build][with-scene-tests]

@guparan guparan merged commit d16dc2a into sofa-framework:master Oct 26, 2018
@guparan guparan added this to the v18.12 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants