[Geomagic] Fix dll export and some enhancements #786

epernod · 2018-09-28T11:54:40Z

Fix:

Dll export + Add config file
Stop scheduler only if thread has successfully started.

Enhancements:

Add: specific method to handle tool buttons
Add: send script event when button are used.
Add: option to not automatically start tool at init but manually start it through a method call. (start at init by default)
Update: m_errorDevice is not anymore a bool but store the HD_DEVICE_ERROR

This PR:

builds with SUCCESS for all platforms on the CI.
does not generate new warnings.
does not generate new unit test failures.
does not generate new scene test failures.
does not break API compatibility.
is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

…mni. will send a scriptEvent if requested.

…return by HD_DEVICE_ERROR

…ice has started.

…hod. Add bool to be able to not automatically init the device at component init but with a munal initDevice call.

epernod · 2018-09-28T11:55:06Z

[ci-build][with-scene-tests]

damienmarchal · 2018-10-03T08:58:13Z

applications/plugins/Geomagic/src/GeomagicDriver.cpp


-    for (std::vector< HDCallbackCode >::iterator i = m_hStateHandles.begin();
+    for (std::vector< HDSchedulerHandle >::iterator i = m_hStateHandles.begin();


for(HDSchedulerHandle : m_hStateHandles){}
:)

hugtalbot · 2018-10-03T09:02:12Z

applications/plugins/Geomagic/src/config.h

@@ -0,0 +1,34 @@
+#pragma once


epernod added 6 commits September 28, 2018 13:30

[Geomagic] Add method to handle and update the button status of the o…

b32278a

…mni. will send a scriptEvent if requested.

[Geomagic] Add config file and export macro to well export class in .dll

40887e7

[Geomagic] Add config file and export macro to well export class in .dll

9690841

[Geomagic] change m_errorDevice from bool to int to return the error …

7bcc490

…return by HD_DEVICE_ERROR

[Geomagic] FIX: stop scheduler only if state is not empty meaning dev…

940f61c

…ice has started.

[Geomagic] Add: move all code related to init inside a initDevice met…

34d3cce

…hod. Add bool to be able to not automatically init the device at component init but with a munal initDevice call.

epernod added enhancement About a possible enhancement location: plugins pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 28, 2018

epernod self-assigned this Sep 28, 2018

guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 3, 2018

damienmarchal reviewed Oct 3, 2018

View reviewed changes

hugtalbot reviewed Oct 3, 2018

View reviewed changes

applications/plugins/Geomagic/src/config.h Outdated

@@ -0,0 +1,34 @@

#pragma once

Copy link

Contributor

hugtalbot Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲

[Geomagic] remove pragma once directive from config.h

8e08754

guparan merged commit b353019 into sofa-framework:master Oct 4, 2018

guparan added this to the v18.12 milestone Oct 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Geomagic] Fix dll export and some enhancements #786

[Geomagic] Fix dll export and some enhancements #786

epernod commented Sep 28, 2018 •

edited by guparan

Loading

epernod commented Sep 28, 2018

damienmarchal Oct 3, 2018

hugtalbot Oct 3, 2018


		for (std::vector< HDCallbackCode >::iterator i = m_hStateHandles.begin();
		for (std::vector< HDSchedulerHandle >::iterator i = m_hStateHandles.begin();

[Geomagic] Fix dll export and some enhancements #786

[Geomagic] Fix dll export and some enhancements #786

Conversation

epernod commented Sep 28, 2018 • edited by guparan Loading

epernod commented Sep 28, 2018

damienmarchal Oct 3, 2018

Choose a reason for hiding this comment

hugtalbot Oct 3, 2018

Choose a reason for hiding this comment

epernod commented Sep 28, 2018 •

edited by guparan

Loading