[SofaBaseMechanics] Fix warning scene mass #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugtalbot
added
pr: fix
|
[ci-build][with-scene-tests] |
epernod
reviewed
Sep 21, 2018
| d_filenameMass.setReadOnly(false) ; | ||
| d_filenameMass.setValue("") ; | ||
| d_filenameMass.setReadOnly(true) ; | ||
| d_filenameMass.setValue("unused") ; |
There was a problem hiding this comment.
what does the "unused" value do ?
There was a problem hiding this comment.
It set a default value to the filename data.
this is maybe not really clean for the filename initialization process. I agree
|
@hugtalbot do you confirm it will solve the issue #779 ? |
|
No it fixes the #724 |
|
yes it is what I wanted to point... cool! |
epernod
approved these changes
Sep 26, 2018
guparan
changed the title
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX some scene files using the mass and having issues with mass datanames (totalmass instead of totalMass)
FIX initialization in UniformMass.cpp due to wrong default filename in Rigid case
Fix #724
This PR:
Reviewers will merge only if all these checks are true.