-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseMechanics] Fix warning scene mass #779
[SofaBaseMechanics] Fix warning scene mass #779
Conversation
[ci-build][with-scene-tests] |
d_filenameMass.setReadOnly(false) ; | ||
d_filenameMass.setValue("") ; | ||
d_filenameMass.setReadOnly(true) ; | ||
d_filenameMass.setValue("unused") ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does the "unused" value do ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It set a default value to the filename data.
this is maybe not really clean for the filename initialization process. I agree
@hugtalbot do you confirm it will solve the issue #779 ? |
No it fixes the #724 |
yes it is what I wanted to point... cool! |
FIX some scene files using the mass and having issues with mass datanames (totalmass instead of totalMass)
FIX initialization in UniformMass.cpp due to wrong default filename in Rigid case
Fix #724
This PR:
Reviewers will merge only if all these checks are true.