Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGuiQt][runSofa] FIX missing resources #758

Merged
merged 3 commits into from
Aug 31, 2018
Merged

[SofaGuiQt][runSofa] FIX missing resources #758

merged 3 commits into from
Aug 31, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Aug 28, 2018 •
edited
Loading

This PR fixes errors like [FileRepository] File icons/back.png NOT FOUND reported recently.

These errors were caused by the fact that SofaGuiQt and runSofa had no idea were to find their resources (if not installed).
Adding and configuring some .ini files will fix that.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 28, 2018
@epernod epernod merged commit e44c02b into sofa-framework:master Aug 31, 2018
@guparan guparan deleted the fix_missing_resources branch October 1, 2018 14:10
@guparan guparan added the pr: backport done This PR has been backported into the release before its milestone. label Oct 4, 2018
@guparan guparan added this to the v18.06 milestone Oct 4, 2018
guparan pushed a commit to guparan/sofa that referenced this pull request Oct 4, 2018
@epernod @guparan
Merge pull request sofa-framework#758 from guparan/fix_missing_resources
df97736 
[SofaGuiQt][runSofa] FIX missing resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @epernod