-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Fix some compilation warnings #755
Conversation
…efined in Topology.h instead of unsigned int or int.
@@ -60,9 +60,9 @@ BaseLink::~BaseLink() | |||
/// Print the value of the associated variable | |||
void BaseLink::printValue( std::ostream& o ) const | |||
{ | |||
std::size_t size = getSize(); | |||
unsigned int size = (unsigned int)getSize(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are finally no using the size_t
Is there a reason to prefer the UI ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case in the next line:
std::string path = getLinkedPath(i);
method getLinkedPath
definition should have a size_t as argument...
…ConnectedElements to return size_t and not unsigned int.
… nbPoints and PointID when using indices. Propagate changes in other containers.
…r EdgeID instead of uint and int.
…_t or element ID instead of uint and int.
…r element ID instead of uint and int.
…ze_t or element ID instead of uint and int.
[ci-build][with-scene-tests] |
…ize_t or element ID instead of uint and int.
…so float to double.
[ci-build][with-scene-tests] |
Fix some size_t to uint int conversion warnings
Fix some double to float warnings
When looping on topology buffer, use the typedef corresponding to id instead of using uint or int.
This PR:
Reviewers will merge only if all these checks are true.