[All] Fix some compilation warnings #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efined in Topology.h instead of unsigned int or int.
hugtalbot
added
pr: clean
hugtalbot
reviewed
Aug 27, 2018
| @@ -60,9 +60,9 @@ BaseLink::~BaseLink() | |||
| /// Print the value of the associated variable | |||
| void BaseLink::printValue( std::ostream& o ) const | |||
| { | |||
| std::size_t size = getSize(); | |||
| unsigned int size = (unsigned int)getSize(); | |||
There was a problem hiding this comment.
You are finally no using the size_t
Is there a reason to prefer the UI ?
There was a problem hiding this comment.
in this case in the next line:
std::string path = getLinkedPath(i);
method getLinkedPath definition should have a size_t as argument...
epernod
added
pr: status wip
…ConnectedElements to return size_t and not unsigned int.
… nbPoints and PointID when using indices. Propagate changes in other containers.
…r EdgeID instead of uint and int.
…_t or element ID instead of uint and int.
…r element ID instead of uint and int.
…ze_t or element ID instead of uint and int.
|
[ci-build][with-scene-tests] |
…ize_t or element ID instead of uint and int.
…so float to double.
|
[ci-build][with-scene-tests] |
epernod
added
pr: status to review
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some size_t to uint int conversion warnings
Fix some double to float warnings
When looping on topology buffer, use the typedef corresponding to id instead of using uint or int.
This PR:
Reviewers will merge only if all these checks are true.